Skip to content

fix(tui): stop leftover toast titles during update install - #13114

Merged
johnnyeric merged 1 commit into
mainfrom
johnnyeric/tui-toast-title-leak
Aug 13, 2026
Merged

fix(tui): stop leftover toast titles during update install#13114
johnnyeric merged 1 commit into
mainfrom
johnnyeric/tui-toast-title-leak

Conversation

@johnnyeric

@johnnyeric johnnyeric commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What

When accepting the TUI update prompt, the installing notification reused the previous toast title (MCP Authentication Required) instead of an update title.

Why

SolidJS createStore merges objects, so currentToast.title leaked from the last toast when the update toast omitted title.

Change

  • Replace the toast with reconcile so omitted fields do not persist
  • Set an explicit Updating title on the install toast
  • Add a regression test for title replacement

How to Test

  1. Trigger an MCP auth toast
  2. Accept an available TUI update
  3. Confirm the installing toast title is Updating, not the MCP title

@kilo-code-bot

kilo-code-bot Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Incremental review of f0eb9d1..1213fd1: the commit-message error surfacing (new CommitMessageFailedError + catchDefect branch) correctly propagates the real error message, the regression test exercises the full HTTP stack with only the LLM boundary stubbed, and the httpapi-exercise changes (git-init opt-in default, --shard support, coverage-mode early return bypassing the runtime import) are internally consistent. The regenerated SDK additions (CommitMessageFailedError, WorktreeSetupReady) match server-side definitions.

Files Reviewed (14 files)
  • .changeset/commit-message-surface-errors.md
  • packages/opencode/src/kilocode/server/httpapi/groups/commit-message.ts
  • packages/opencode/src/kilocode/server/httpapi/handlers/commit-message.ts
  • packages/opencode/test/kilocode/server/commit-message-no-changes.test.ts
  • packages/opencode/test/kilocode/server/httpapi-exercise-scenarios.ts
  • packages/opencode/test/server/httpapi-exercise/dsl.ts
  • packages/opencode/test/server/httpapi-exercise/index.ts
  • packages/opencode/test/server/httpapi-exercise/routing.ts
  • packages/opencode/test/server/httpapi-exercise/runtime.ts
  • packages/opencode/test/server/httpapi-exercise/types.ts
  • packages/sdk/js/src/v2/gen/types.gen.ts
  • packages/sdk/openapi.json
  • packages/tui/src/app.tsx
  • packages/tui/src/ui/toast.tsx
Previous Review Summary (commit f0eb9d1)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit f0eb9d1)

Status: No Issues Found | Recommendation: Merge

lgtm — the reconcile fix correctly prevents stale toast fields from leaking across toast.show calls, the explicit Updating title matches surrounding patterns, and the regression test exercises the real store implementation without mocks.

Files Reviewed (4 files)
  • .changeset/tui-toast-title-leak.md
  • packages/tui/src/app.tsx
  • packages/tui/src/ui/toast.tsx
  • packages/tui/test/kilocode/toast.test.tsx

Reviewed by kimi-k3 · Input: 96.2K · Output: 8.2K · Cached: 556.6K

Review guidance: REVIEW.md from base branch main

@johnnyeric
johnnyeric marked this pull request as draft August 13, 2026 18:58
@johnnyeric
johnnyeric marked this pull request as ready for review August 13, 2026 19:03
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 13, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0eb9d10ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/tui/src/ui/toast.tsx Outdated
@johnnyeric
johnnyeric force-pushed the johnnyeric/tui-toast-title-leak branch from de6f390 to cd35c4e Compare August 13, 2026 19:12
@johnnyeric
fix(tui): stop leftover toast titles during update install
1213fd1 
SolidJS store merge kept the previous toast title when the next toast omitted it, so the update prompt reused "MCP Authentication Required".
@johnnyeric
johnnyeric force-pushed the johnnyeric/tui-toast-title-leak branch from cd35c4e to 1213fd1 Compare August 13, 2026 19:12
@johnnyeric
johnnyeric merged commit b5f5d9f into main Aug 13, 2026
31 checks passed
@johnnyeric
johnnyeric deleted the johnnyeric/tui-toast-title-leak branch August 13, 2026 19:34
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
@johnnyeric
fix(tui): stop leftover toast titles during update install (Kilo-Org#…
bf2a51d 
…13114)

SolidJS store merge kept the previous toast title when the next toast omitted it, so the update prompt reused "MCP Authentication Required".
@kilo-maintainer kilo-maintainer Bot mentioned this pull request Aug 14, 2026
Merged
@github-actions github-actions Bot mentioned this pull request Aug 19, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@chrarnoldus chrarnoldus chrarnoldus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnnyeric @chrarnoldus